expose ParseQuery to parse query struct #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8m
reviewed
Jul 19, 2019
Co-Authored-By: Ariel Mashraki <[email protected]>
Co-Authored-By: Ariel Mashraki <[email protected]>
Co-Authored-By: Ariel Mashraki <[email protected]>
|
sweet, thanks for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just exposing a parse function that accepts the
Queryobject to allow for greater control. Primary use case is to allow cleaner web framework integration and allow flatter query parameters ie?query={limit=..,offset=..}vs?limit=..&offset=..&filter={..}.On the web framework side this allows the framework to handle things like defaults and validation so that it can be consistent with the rest of the web project. Depending on the web framework (gin,goa) this may also allow it to auto document the structure better.