Merged
Conversation
swapydapy
approved these changes
Jun 18, 2025
Member
|
@kthota-g Can you add this to the PR description with the version this should be for? |
Contributor
Author
sg. There are additional interface changes required to merge along with this PR. I will tag the release once the PR for other changes are in. |
Support for list and delete push notification config. Removes the push_notifier from the SDK. This will be merged into push_notif_refactoring branch (#212) and then merged into main along with refactoring changes. --------- Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
Contributor
Author
|
@swapydapy can you review this one more time? The changes to support multiple configs are complete and have updated the description with changes required for migration. |
swapydapy
requested changes
Jun 28, 2025
swapydapy
approved these changes
Jul 1, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
refactor!: Removes
push_notifierinterface from the SDK and introducespush_notification_config_storeandpush_notification_senderfor supporting push notifications.feat: Adds support for more than one
push_notification_configper task.feat: Adds support for List and Delete push notification configurations.
Following is an example for the changes required with new version:
Previously:
Now:
Release-As: 0.2.11
END_COMMIT_OVERRIDE