Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add manage_containers.py #27

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Add manage_containers.py #27

wants to merge 25 commits into from

Conversation

Willenst
Copy link
Contributor

Hello, it looks like my previous PR #22 was broken, so here is its recovery

@a13xp0p0v
Fix the "dockerman" bug
c93a0be 
Checking groups in wrap_docker_command() is not reliable.
For example, the `dockerman` user in `dockerman` group makes this check fail.
Let's do it properly and try the `docker ps` command.

Thanks to @Willenst for finding this bug.
@a13xp0p0v
Copy link
Owner

Hello @Willenst,

Thanks for your work!

I've added some fixes (including one for #28) and some style improvements.

Currently, I see a possible problem:
I think Container.check() should make sure that there is a single container with this pair of compilers.
That would make the code less error-prone.
What do you think about that?

@Willenst Willenst force-pushed the merge2 branch 3 times, most recently from 4a02da3 to 0559ca0 Compare October 28, 2024 12:00
@Willenst
Fix the "dockerman" bug in other scripts
f9eace9 
Checking groups in "groups | grep docker > /dev/null" is not reliable.
For example, the `dockerman` user in `dockerman` group makes this check fail.
Let's do it properly in a more strict way.
@Willenst Willenst force-pushed the merge2 branch 2 times, most recently from 0f10184 to 62e3e6c Compare November 1, 2024 15:48
@a13xp0p0v
Copy link
Owner

Hi @Willenst,

Could you please also reorder clang and gcc in the --list output?

I've added some fixes in make_linux.py and renamed it to build_linux.py.
It will allow better command autocompletion.

Now you can remove the obsolete shell scripts (because we have manage_containers.py).

And please update the whole README.

Thanks for the collaboration! 👍

@Willenst
Copy link
Contributor Author

Hello @a13xp0p0v.

I decided to reorder clang and gcc pretty much everywhere to achieve uniformity, I hope I didn't overdo it.

Also removed “obsolete” shell scripts and updated README for them and for changes in python scripts.

I also added a couple of beauty features to the README, like text and subparagraph highlights, I hope it will look better this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Willenst @a13xp0p0v