Give user a choice to choose which container to build #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a fucntion for every container build, user passes the argument and builds only the version user asked for. This saves a lot of time and space on the disk If no arguments are provided all the containers will be built. I kept it that way since I didn't wanna change the legacy behaviour. Signed-off-by: Mukesh Kumar Chaurasiya <[email protected]>
|
Hello @mchauras-linux, Thanks for your work! I've improved your pull request a bit: Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a fucntion for every container build, user passes the argument and builds only the version user asked for.
This saves a lot of time and space on the disk
If no arguments are provided all the containers will be built. I kept it that way since I didn't wanna change the legacy behaviour.