Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to choose a specific version of the container image to build / Stop/Remove all running containers before removing images #11

Closed
wants to merge 1 commit into from
Closed

Conversation

joseigor
Copy link

@joseigor joseigor commented Jun 13, 2023

This PR includes:

  • Allow the user to choose specific versions to build as well as all versions. (Building all docker's images for all supported versions GCC/Clang is time/space consuming and is likely this is not needed in all cases.)
  • Refactor of rm_constainers.sh to stop and remove all running containers before removing the associated docker image.
  • Move common variables to the config. sh file.

@joseigor joseigor changed the title Allow the user to choose a specific version of the container image to build. Allow the user to choose a specific version of the container image to build / Stop/Remove all running containers before removing images Jun 13, 2023
@joseigor joseigor marked this pull request as draft June 13, 2023 20:42
@joseigor joseigor marked this pull request as ready for review June 13, 2023 23:25
…ontainer image.

- Stop and remove containers before image is removed.
- Move supported GCC and Clang version variables to config.sh.
@joseigor joseigor closed this by deleting the head repository Jun 16, 2023
@a13xp0p0v
Copy link
Owner

Hello @joseigor,

Excuse me for such a delay -- I missed the notification :(

I like the idea of your PR!

I'm not excellent in bash, so I'll try to reimplement your logic in python.

I'll kindly ask you to have a look when it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants