Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail loudly when kernel build fails #3

Closed
xairy opened this issue Aug 12, 2020 · 4 comments
Closed

Fail loudly when kernel build fails #3

xairy opened this issue Aug 12, 2020 · 4 comments

Comments

@xairy
Copy link
Contributor

xairy commented Aug 12, 2020

Currently it's not very clear when a build fails, as both a failed and a successful builds have the same last few lines:

Running the container returned 0
See build log: .../build_log.txt

[+] Done, see the results
a13xp0p0v added a commit that referenced this issue Sep 14, 2020
@a13xp0p0v
Don't lose the return value of kernel build
598d56a 
Let's avoid using `tee` for saving the kernel build log.
It swallows the return value from `make` that runs in Docker container.
Let's instead save the build log from outside.

That fixes the issue #3 and makes build logs more verbose.
@a13xp0p0v
Copy link
Owner

Hi @xairy
May I ask you to try it now?
Thanks!

@xairy
Copy link
Contributor Author

xairy commented Sep 14, 2020

Looks much better now, thanks!

[+] at the end is still a bit confusing, but I think this is fine.

      LD [M]  fs/nfs/flexfilelayout/nfs_layout_flexfiles.o
      AR      fs/nfs/built-in.a
      AR      fs/built-in.a
    make[1]: Leaving directory '/home/user/out'
    make: *** [Makefile:185: __sub-make] Error 2
Running the container returned 2
See build log: .../build_log.txt

[+] Done, see the results

@a13xp0p0v
Copy link
Owner

This tool can build several kernels during one run (if you specify several compilers with -c).
So this [+] Done shows that the tool really finished its jobs :)

@xairy
Copy link
Contributor Author

xairy commented Sep 14, 2020 •
edited
Loading

OK, SGTM, thank you for the fix! :)

@xairy xairy closed this as completed Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@a13xp0p0v @xairy