Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interrupting kernel build with Ctrl+C hangs the terminal #1

Closed
xairy opened this issue Jul 15, 2020 · 2 comments
Closed

Interrupting kernel build with Ctrl+C hangs the terminal #1

xairy opened this issue Jul 15, 2020 · 2 comments

Comments

@xairy
Copy link
Contributor

xairy commented Jul 15, 2020

Can be resolved manually with sending a kill -9 to the make process.
a13xp0p0v added a commit that referenced this issue Jul 16, 2020
@a13xp0p0v
Run docker in non-interactive mode from subprocess.Popen()
5746e0b 
What a tricky bug!

Currently subprocess.Popen() starts 'docker run' with '-it' arguments.
That makes docker run in interactive mode and breaks the delivery of
KeyboardInterrupt in python. So Ctrl+C sometimes doesn't work properly.

Let's add a new '-n' argument for run_container.sh to disable docker
interactive mode when needed.

That fixes the issue #1.
@a13xp0p0v
Copy link
Owner

Hi @xairy,
I'm glad that you use this tool!
Thanks for the report.

That was a tricky bug:
subprocess.Popen() starts docker run with -it arguments.
That makes docker run in interactive mode, but breaks the delivery of
KeyboardInterrupt in python. So Ctrl+C sometimes doesn't work properly.

I added a new -n argument for run_container.sh to disable docker interactive mode
when needed. I see that the issue is fixed. Can you reproduce it?

@xairy
Copy link
Contributor Author

xairy commented Jul 16, 2020

Hi Alex,

Now Ctrl+C works, thanks for the fix and for the tool!

@xairy xairy closed this as completed Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@a13xp0p0v @xairy