Do not confuse TAP::Parser by mixing up stderr with stdout.

This avoids false psotivie failures on FreeBSD-CI which suffers most from this issue. Fixes openssl#23992 Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Bernd Edlinger <[email protected]> (Merged from openssl#25613)
a-mair · Oct 23, 2024 · 3d3bb26 · 3d3bb26
1 parent 76783a8
commit 3d3bb26
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/util/perl/TLSProxy/Proxy.pm b/util/perl/TLSProxy/Proxy.pm
@@ -290,8 +290,14 @@ sub start
     if ($self->debug) {
         print STDERR "Server command: $execcmd\n";
     }
+    my $sin = undef;
+    my $sout = undef;
+    if ("$^O" eq "MSWin32") {
+        $pid = IPC::Open2::open2($sout, $sin, $execcmd) or die "Failed to $execcmd: $!\n";
+    } else {
+        $pid = IPC::Open3::open3($sin, $sout, undef, $execcmd) or die "Failed to $execcmd: $!\n";
+    }
 
-    $pid = IPC::Open2::open2(my $sout, my $sin, $execcmd) or die "Failed to $execcmd: $!\n";
     $self->{serverpid} = $pid;
 
     # Process the output from s_server until we find the ACCEPT line, which