feat: templ.Join method renders multiple components into a single component #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joerdav
reviewed
Sep 24, 2024
join.go
Outdated
| "io" | ||
| ) | ||
|
|
||
| // Pass any number of templ.Components to get a single templ.Component with the components rendered |
There was a problem hiding this comment.
Go function comments should begin with the name of the documented function.
Suggested change
| // Pass any number of templ.Components to get a single templ.Component with the components rendered | |
| // Join returns a single `templ.Component` that will render provided components in order. | |
| // If any of the components return an error the Join component will immediately return with the error. |
| @@ -235,6 +235,49 @@ func main() { | |||
| <p>Dynamic contents</p> | |||
| </div> | |||
| ``` | |||
| ## Joining Components | |||
| With your templ components you can use `templ.Join` to generate a single `templ.Component` from your components. | |||
There was a problem hiding this comment.
Suggested change
| With your templ components you can use `templ.Join` to generate a single `templ.Component` from your components. | |
| Components can be aggregated into a single Component using `templ.Join`. |
join_test.go
Outdated
| } | ||
| return nil | ||
| }) | ||
| components := []templ.Component{hello, world} |
There was a problem hiding this comment.
These definitions would probably be cleaner defined in the table test directly.
There was a problem hiding this comment.
I initialise them in the test structs now.
a-h
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heyoo,
I have a PR for the proposal suggested in this issue I followed the example solution you given @a-h. I have updated the docs too to explain the new Join method with an example in the
Temple Compositionsection. Let me know what you think. I will rename the commit message as part of any changes in the feedback