Allow script components to be rendered inline #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-h
requested changes
Nov 9, 2023
a-h
approved these changes
Nov 11, 2023
|
Looks like switching to slices might have broken something... Will look on Sunday 👀 |
|
Yes, that was a bad idea of mine then, sorry! :) thanks for looking into it! |
|
Alright, should be fixed! |
a-h
approved these changes
Nov 13, 2023
|
Thanks! |
|
I literally just ran into this use case today while learning templ, what a coincidence and thanks for this! |
ross96D
pushed a commit
to ross96D/templ
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows templ to render
scriptcomponents, which is useful for inline Javscript. As of now,scriptcomponents can really only be used within HTML attributes. This extends the!usage to now enable embedding Javascript outside HTML attributes.This fixes #231
I've also added a test case to show how it would be used (and what would be rendered). I've ensured that things should be backwards compatible, the only things that new generator runs would introduce is the new
CallInlinestruct member (which is only called if you use this new functionality).