Alternate height encoding #375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Support set_item_disabled() in inspector for USAGE_ENUM
MJacred
force-pushed
the
alternate_height_encoding
branch
from
ece4d24
to
c32ce58
Compare
|
FYI #316 (comment) |
|
will close this PR due to 32-bit support (e49ac9a) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #368
NOTE: based on my PR #369 to allow me to import heightmaps of sufficient quality. Will rebase once that PR has been merged
Therefore, please only see newest commit: Change heightmap encoding
On import:
On Export, calculated:
before, auto-calculated heights on export were:
Benchmarking
new encoding+decoding: max diff 0-0.000977 over 7229.061 msecs
previous encoding+decoding: max diff 0-0.
000975over 7304.282 msecsnew encoding+decoding: max diff 0-0.000977 over 7148.446 msecs
previous encoding+decoding: max diff 0-0.
000976over 7224.242 msecsnew encoding+decoding: max diff 0-0.000977 over 7099.373 msecs
previous encoding+decoding: max diff 0-0.000975 over 7174.645 msecs
current progress result: Basically equal precision loss but faster and output seems consistent (rounding in current logic seems to round differently sometimes)