Skip to content

perf(write-path): remove artificial write delays by default (part of #1375) #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edelauna merged 13 commits into from
Oct 6, 2026
Merged

perf(write-path): remove artificial write delays by default (part of #1375) #1381

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4ab3bf4
perf(write-path): remove artificial write delays by default (part of …
easonliang28 Aug 27, 2026
3f8db83
test(webview): cover writeDelayMs in getStateToPostToWebview
easonliang28 Aug 27, 2026
44b6791
test(dv): assert default saveChanges delay via DEFAULT_WRITE_DELAY_MS
easonliang28 Aug 27, 2026
6548013
fix(fws): use the shared write-delay default in the pre-hydration web…
easonliang28 Aug 28, 2026
309ffd6
chore(ci): empty commit — re-trigger CI and the CodeRabbit current-he…
easonliang28 Aug 30, 2026
065bef1
Merge commit '0d937c050810ebc305b34368bf6d6ae8c1f89966' into fix/writ…
easonliang28 Sep 4, 2026
abb8a21
test(webview): replace the any cast on the globalState mock with a ty…
easonliang28 Sep 23, 2026
1ff2d59
Merge branch 'main' into fix/write-delay-default
easonliang28 Sep 23, 2026
cd96d25
Merge branch 'main' into fix/write-delay-default
easonLiangWorldedtech Sep 28, 2026
47c06b2
test(core): replace any cast on globalState.get with the typed reassi…
Sep 28, 2026
6bfdbf0
Merge remote-tracking branch 'upstream/main' into fix/write-delay-def…
Oct 2, 2026
eaba863
Merge commit 'refs/shapes/upstream-main' into fix/write-delay-default
Oct 2, 2026
e5d4a77
test(editor): pin the default write delay to zero
Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/types/src/global-settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,12 @@ import { languagesSchema } from "./vscode.js"

/**
* Default delay in milliseconds after writes to allow diagnostics to detect potential problems.
* This delay is particularly important for Go and other languages where tools like goimports
* need time to automatically clean up unused imports.
* Defaults to 0: the write path adds no artificial pacing by default, and post-save
* diagnostics are reported after the (zero) delay. Users who rely on auto-formatters that
* settle asynchronously (e.g. goimports for Go) can raise this setting to give formatters
* time to settle before diagnostics are captured.
*/
export const DEFAULT_WRITE_DELAY_MS = 1000
export const DEFAULT_WRITE_DELAY_MS = 0
Comment thread
easonLiangWorldedtech marked this conversation as resolved.

/**
* Default values for the "auto-close files Zoo opened" settings.
Expand Down
2 changes: 0 additions & 2 deletions src/core/tools/WriteToFileTool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import path from "path"
import delay from "delay"
import fs from "fs/promises"

import { type ClineSayTool, DEFAULT_WRITE_DELAY_MS } from "@roo-code/types"
Expand Down Expand Up @@ -146,7 +145,6 @@ export class WriteToFileTool extends BaseTool<"write_to_file"> {
true,
)

await delay(300)
task.diffViewProvider.scrollToFirstDiff()

let unified = fileExists
Expand Down
4 changes: 2 additions & 2 deletions src/core/webview/__tests__/ClineProvider.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1409,14 +1409,14 @@ describe("ClineProvider", () => {
expect(state.language).toBe("pt-BR")
})

test("writeDelayMs defaults to 1000ms", async () => {
test("writeDelayMs defaults to DEFAULT_WRITE_DELAY_MS", async () => {
// Mock globalState.get to return undefined for writeDelayMs
;(mockContext.globalState.get as any).mockImplementation((key: string) => {
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
return key === "writeDelayMs" ? undefined : null
})

const state = await provider.getState()
expect(state.writeDelayMs).toBe(1000)
expect(state.writeDelayMs).toBe(DEFAULT_WRITE_DELAY_MS)
Comment thread
coderabbitai[bot] marked this conversation as resolved.
})

test("getState applies fallback defaults for write, diff, and terminal settings", async () => {
Expand Down
Loading