Mvs schemazen create tables #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 12, 2016 16:59
…e-tables # Conflicts: # model/Models/Database.cs # model/Schemazen.Library.nuspec
| @@ -5,7 +5,7 @@ | |||
| namespace SchemaZen.Library.Command { | |||
| public class CreateCommand : BaseCommand { | |||
|
|
|||
| public void Execute(string databaseFilesPath) | |||
| public void CreateDatabases(string databaseFilesPath) | |||
There was a problem hiding this comment.
Does this create a single database or multiple?
There was a problem hiding this comment.
ow Rick, you got me there. It creates a single DB.
|
Did you run the schemazen tests locally as well? |
|
Yes, @colin-hanson-zocdoc all Schemazen tests working. |
| @@ -20,7 +20,19 @@ public void Execute(string databaseFilesPath) | |||
| throw new InvalidOperationException(msg); | |||
| } | |||
|
|
|||
| db.CreateFromDir(Overwrite, databaseFilesPath, Logger.Log); | |||
| db.CreateDBFromDir(databaseFilesPath, Logger.Log); | |||
| Logger.Log(TraceLevel.Info, Environment.NewLine + "Database created successfully."); | |||
There was a problem hiding this comment.
This should include the database name
|
|
marcio-santos-zocdoc
force-pushed
the
mvs-schemazen-create-tables
branch
from
57b3d0e to
61bda32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Zocdoc/ci-devs
We need to split the Execute function on two in order to lock only the Database creation.
Tested locally, Scout tests running green.