fix: Make sure that images can be built on arm64 #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens because pymssql does not have wheels for arm64
|
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -13,7 +13,7 @@ | |||
| ENV PDM_VERSION 2.16.1 | |||
|
|
|||
| RUN apt-get update \ | |||
| && apt-get --no-install-recommends install -y docker \ | |||
| && apt-get --no-install-recommends install -y docker build-essential pkg-config freetds-dev libssl-dev libkrb5-dev \ | |||
Check notice
Code scanning / SonarCloud
Arguments in long RUN instructions should be sorted Low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow images to be built on arm64
Why
If emulation is used, it is slow and a few errors happen making the backend not runnable
I have read and understood the Contribution Guidelines.