-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2 of User/Organization Account Module #431
Conversation
I see Some sonar issues,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. As this is v2 of same account app with changes mentioned in description.
Some of it dependent models will be raised as separate PR as author mentioned
@muhammad-ali-e One doubt, will we be removing the previous version after the test-runs ? |
@athul-rs We will only remove the previous version once we have fully transitioned to the new feature and all QA checks are completed. Until then, we will keep all V1 applications, including their tables and schema, to ensure continuity and avoid any disruption. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the overall code.
Only doubt remains on the duplicate code we are adding to OSS, please proceed if this is alright. cc: @hari-kuriakose
Bypassing Sonar duplication issue. This is because the Django apps are duplicated purposefully, which is the less messier path. Similarly it's best the models too are separate in order to prevent any conflict with prior logic. Also once we complete the migration, we will remove all the older Django apps. |
We can take care of duplication when we delete v1 eventually. Bypassing. |
|
Quality Gate failedFailed conditions |
What
Why
How
tenant_context(organization)
with newUserContext
methods.StateStore
to store and manage the organization ID in the current context.TenantMixin
and redundant methods.OrganizationMixin
for better model structuring.Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
multi_tenancy_v2
.Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.