UN-2932 [FIX] hitl rules check issue fix #1648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test ResultsSummary
Runner Tests - Full Report
SDK1 Tests - Full Report
|
|
vishnuszipstack
requested review from
Deepak-Kesavan,
athul-rs,
jagadeeswaran-zipstack and
muhammad-ali-e
Contributor
Summary by CodeRabbit
WalkthroughChanges to the HITL (Human-in-the-Loop) decision flow in destination_connector.py now enable rule evaluation for all files, not just pre-selected ones. The Changes
Sequence DiagramsequenceDiagram
participant check as _check_and_handle_hitl
participant should as _should_handle_hitl
participant service as Manual Review Service
participant validate as validate_db_rule
check->>should: tool_execution_result, file_hash
activate should
rect rgb(240, 248, 255)
note over should: Check pre-selection status
should->>should: is_manualreview_required?
end
alt Pre-selected (old path)
should->>validate: use rule evaluation
else Not pre-selected (new path)
should->>should: wrap tool_execution_result
rect rgb(255, 250, 240)
note over should: Normalize result shape
end
should->>validate: use wrapped_result
end
validate->>service: rule evaluation
service-->>validate: rule outcome
validate-->>should: HITL decision
deactivate should
should-->>check: return bool
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deepak-Kesavan
approved these changes
Nov 6, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to Reviews > Disable Cache setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (1)
workers/shared/workflow/destination_connector.py(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
How
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.