Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPC test output types should be taken from the IPC state, not from th… #903

Merged
merged 1 commit into from
Nov 10, 2020
Merged

IPC test output types should be taken from the IPC state, not from th… #903

merged 1 commit into from
Nov 10, 2020

Conversation

jjcnn
Copy link
Contributor

@jjcnn jjcnn commented Nov 10, 2020

…e gold state

@vaivaswatha
Copy link
Contributor

Rather than switching gold with output, shouldn't we parse the output type too and assert that it's equivalent to gold type?

@vaivaswatha
Copy link
Contributor

Rather than switching gold with output, shouldn't we parse the output type too and assert that it's equivalent to gold type?

Jacob's offline reply: it will be caught anyway in the output diff and easier to diagnose then.

@jjcnn jjcnn merged commit 97b38ca into master Nov 10, 2020
@jjcnn jjcnn deleted the test_ipc_output_types_taken_from_ipc_client branch November 10, 2020 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaivaswatha vaivaswatha vaivaswatha approved these changes

@anton-trunov anton-trunov Awaiting requested review from anton-trunov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjcnn @vaivaswatha