Conversation
valeryz
reviewed
Dec 12, 2022
| impl<'config> Runtime<'config> { | ||
| impl Runtime { | ||
| /// Create a new runtime with given code and data. | ||
| pub fn new( |
There was a problem hiding this comment.
I think we better not break the public APIs? What if we keep accepting a reference to config, but just clone it inside the new method?
I guess you won't need the 'config lifetime in this case too, as the reference will only live long enough to be cloned.
bzawisto
force-pushed
the
ZIL-4652-SputnikVM-Execution-in-Continuation-Passing-Style
branch
from
c193343 to
4fab033
Compare
valeryz
approved these changes
Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.