Repository navigation
Fix OnMiss not firing in all cases in Distributed Cache - #211
Merged
jodydonetti merged 2 commits intoMar 30, 2024
Merged
Conversation
ConMur
marked this pull request as ready for review
March 11, 2024 18:29
Collaborator
|
Hi @ConMur and thanks for using FusionCache! Sorry for the delay but I was at the MVP Global Summit and was not able to look into this. Thanks! |
Collaborator
|
I'm looking into this, will update soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation of DistributedCacheAccessor (both Sync and Async) the only time
_events.OnMissfires is whenThe bug is in case 1. The code currently checks that the value returned from the
IDistributedCacheis non null and returns early if it is null. This means we never start de-serialization and therefore never call_events.OnMiss. This leads to inaccurate distributed cache miss counters.To fix this I added
_events.OnMissto the if block that checks the result from theIDistributedCache. This will cause the OnMiss event to also be triggered in the case of an exception from theIDistributedCache. If this behavior is not desired I can update the code to only fire the event when the result from theIDistributedCacheis null.