Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it'll be the best if we have dark theme #6

Open
khuctrongoc opened this issue Aug 23, 2023 · 6 comments
Open

it'll be the best if we have dark theme #6

khuctrongoc opened this issue Aug 23, 2023 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@khuctrongoc
Copy link

it'll be the best if we have dark theme

@ZhangJian1713 ZhangJian1713 added the enhancement New feature or request label Sep 1, 2023
@ZhangJian1713
Copy link
Owner

Yes, it is good, but I don't think it is a high priority. Please be patient and wait. Looking forward to anyone interested in contributing PR for this.

@ZhangJian1713 ZhangJian1713 added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 1, 2023
@zero-enthusiasm
Copy link

So I had a quick go at this. Ideally it should mirror the VSCode theme which can be done using CSS variables, but this seems quite difficult with the version of antd it currently uses (4.x I think?). I've never used atnd but it looks like 5.x introduces quiet simple theming through ConfigProvider which would make it quite easy I think. Otherwise we can get close by spamming bg/fg color into all the styles by that's not so great.

@ryanwwest
Copy link

Thanks for the awesome plugin. This would be a great addition.

@zero-enthusiasm
Copy link

I have re-implemented this extension with a dark theme: https://github.com/zero-enthusiasm/vscode-project-image-browser

@ryanwwest
Copy link

Looks great. Maybe @ZhangJian1713 could merge this as a PR or the other open one.

@immiProgrammer
Copy link

plz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants