Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static methods for extra convenience, infer port if http #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Danappelxx
Copy link
Contributor

Also added a couple tests that show old vs new functionality.

@paulofaria
Copy link
Contributor

did you take a look at https://github.com/VeniceX/HTTPSClient? it's beyond HTTPClient in features.. instead of updating both independently I want to unify the implementation and just give it different stream implementations. so we would have https://github.com/Zewo/HTTPClient with the common implementation and then https://github.com/VeniceX/HTTPClient and https://github.com/VeniceX/HTTPSClient would be just the initializers injecting the stream.

@Danappelxx
Copy link
Contributor Author

I think it would be very confusing to have two HTTPClient repositories. Either way, if that's a blocker here, we should get that done first.

@Danappelxx Danappelxx closed this Jun 29, 2016
@Danappelxx Danappelxx reopened this Jun 29, 2016
@paulofaria
Copy link
Contributor

Maybe we could put the Client and Server base implementations at HTTP? Not sure about that because it could make interoperability worse.

@Danappelxx
Copy link
Contributor Author

I think that makes sense - I don't think the possible clashing will be an issue (if it is, we'll find out 😛).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants