Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt (text) color of events to background #179

Open
werthen opened this issue Jun 8, 2017 · 9 comments
Open

Adapt (text) color of events to background #179

werthen opened this issue Jun 8, 2017 · 9 comments
Assignees

Comments

@werthen
Copy link
Member

werthen commented Jun 8, 2017

@werthen werthen self-assigned this Jun 8, 2017
@wschella
Copy link
Member

wschella commented Jun 9, 2017

@werthen: in what way are you planning to use this gem? The images above which most of the text is rendered are not part of this project right?

@werthen
Copy link
Member Author

werthen commented Jun 9, 2017 via email

@wschella
Copy link
Member

wschella commented Jun 9, 2017

You'd have to fetch from the img url during compilatation to do that with a gem tough. That feels a bit finicky.

@wschella
Copy link
Member

wschella commented Jun 9, 2017

We should inline the images during compilatation as well then, which might be something we should do anyway.

@werthen
Copy link
Member Author

werthen commented Jun 9, 2017 via email

@wschella
Copy link
Member

I guess these things need to happen in the preprocessor:

  • Find all absolute links
  • Filter those with image extention
  • Download image
  • Save image in output
  • Replace absolute external link with internal link

This would also improve performance, since everything comes from the same domain.

@werthen
Copy link
Member Author

werthen commented Oct 12, 2017 via email

@wschella
Copy link
Member

As long as this is only in a production environment, compile time doesn't matter too much I think. Is there a decent way to select only the url's from the latest changes? Also moving this to it's own issue.

@werthen
Copy link
Member Author

werthen commented Oct 12, 2017

not entirely, I think it will recompile every time, which might be a bit problematic. There's no way to get only the hash from a random image on the internet. Maybe this is a functionality we could add to ZEUSWPI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants