-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt (text) color of events to background #179
Comments
@werthen: in what way are you planning to use this gem? The images above which most of the text is rendered are not part of this project right? |
I was thinking of maybe extracting a primary color from the image, and then
use the text color which contrasts the most with that primary color.
…On Jun 9, 2017 13:37, "Wout Schellaert" ***@***.***> wrote:
@werthen <https://github.com/werthen>: in what way are you planning to
use this gem? The images above which most of the text is rendered are not
part of this project right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#179 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADrIzFXyUZSAI-P_YCImYnVNfFLupXvjks5sCS5ggaJpZM4N0aEZ>
.
|
You'd have to fetch from the img url during compilatation to do that with a gem tough. That feels a bit finicky. |
We should inline the images during compilatation as well then, which might be something we should do anyway. |
Only when compiling in a production environment, but yeah, i'm not sure how
to pull that off really efficiently. It would be a nice experiment
…On Jun 9, 2017 14:53, "Wout Schellaert" ***@***.***> wrote:
You'd have to fetch from the img url during compilatation to do that with
a gem tough. That feels a bit finicky.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#179 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADrIzNdoGmELyBTF6wMWogVNEhKGz0fEks5sCUA8gaJpZM4N0aEZ>
.
|
I guess these things need to happen in the preprocessor:
This would also improve performance, since everything comes from the same domain. |
This would definitely increase our compile time A LOT, but then again, we
could cache these things in the output folder of the site. Extremely low
priority but it would add another interesting layer to our static site by
gathering external assets.
Sort of related to #164, we could probably reuse a bit of the code to
handle that link rot?
|
As long as this is only in a production environment, compile time doesn't matter too much I think. Is there a decent way to select only the url's from the latest changes? Also moving this to it's own issue. |
not entirely, I think it will recompile every time, which might be a bit problematic. There's no way to get only the hash from a random image on the internet. Maybe this is a functionality we could add to ZEUSWPI? |
Relevant links
The text was updated successfully, but these errors were encountered: