Skip to content

Commit

Permalink
Merge pull request #1032 from ZeusWPI/chore/bump-v35
Browse files Browse the repository at this point in the history
Bump to API level 35
  • Loading branch information
niknetniko authored Jan 12, 2025
2 parents ee543cd + e8b6b44 commit 1d689ae
Show file tree
Hide file tree
Showing 7 changed files with 30 additions and 55 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ jobs:
java-version: 17
distribution: temurin
cache: 'gradle'
# TODO: remove once no longer using RC
- name: Setup Android SDK
uses: android-actions/setup-android@v3
- name: Test with Gradle
run: ./gradlew ${{ matrix.command }}
lint:
Expand All @@ -31,6 +34,9 @@ jobs:
java-version: 17
distribution: temurin
cache: 'gradle'
# TODO: remove once no longer using RC
- name: Setup Android SDK
uses: android-actions/setup-android@v3
- name: Lint with Gradle
run: ./gradlew lint
build:
Expand All @@ -47,6 +53,9 @@ jobs:
java-version: 17
distribution: temurin
cache: 'gradle'
# TODO: remove once no longer using RC
- name: Setup Android SDK
uses: android-actions/setup-android@v3
- name: Set up secrets.properties
run: echo "$SECRETS_PROPERTIES" | base64 --decode > app/secrets.properties
env:
Expand Down
8 changes: 4 additions & 4 deletions android-versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# IMPORTANT: this file is read as a "Java Properties file" by Gradle
# AND as a "TOML file" by Nix. So it needs to be valid in both.
# Since properties strings are not quoted, we unquote the values in Gradle.
cmdLineToolsVersion = "12.0-rc15"
platformToolsVersion = "34.0.5"
buildToolsVersions = "34.0.0"
platformVersions = "34"
cmdLineToolsVersion = "16.0-rc01"
platformToolsVersion = "35.0.2"
buildToolsVersions = "35.0.0-rc4"
platformVersions = "35"
2 changes: 1 addition & 1 deletion app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ android {
compileSdk = versions.getProperty("platformVersions").toInt()
applicationId = "be.ugent.zeus.hydra"
minSdk = 21
targetSdk = 34
targetSdk = 35
versionCode = 37300
versionName = "3.7.3"
vectorDrawables.useSupportLibrary = true
Expand Down
54 changes: 10 additions & 44 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
platformToolsVersion = androidVersions.platformToolsVersion;
buildToolsVersions = [ androidVersions.buildToolsVersions ];
includeEmulator = true;
emulatorVersion = "34.1.9";
emulatorVersion = "35.2.5";
includeSystemImages = true;
systemImageTypes = [ "google_apis_playstore" ];
abiVersions = [ "x86_64" ];
Expand All @@ -49,7 +49,7 @@
hydra-android = pkgs.devshell.mkShell {
name = "hydra-android";
packages = [
androidComposition.androidsdk pkgs.jdk11 pkgs.git pkgs.androidStudioPackages.beta
androidComposition.androidsdk pkgs.jdk11 pkgs.git
];
env = [
{
Expand Down
6 changes: 3 additions & 3 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ livedata = '2.8.7'
okhttp3 = '4.12.0'
recordbuilder = '44'
room = '2.6.1'
buildtool = '8.5.2'
buildtool = "8.7.3"

[libraries]
android-build-tool = { module = 'com.android.tools.build:gradle', version.ref = 'buildtool' }
androidx-appcompat = { module = 'androidx.appcompat:appcompat', version = '1.7.0' }
androidx-browser = { module = 'androidx.browser:browser', version = '1.8.0' }
androidx-cardview = { module = 'androidx.cardview:cardview', version = '1.0.0' }
androidx-constraintlayout = { module = 'androidx.constraintlayout:constraintlayout', version = '2.2.0' }
androidx-core = { module = 'androidx.core:core', version = '1.13.1' }
androidx-core = { module = 'androidx.core:core', version = '1.15.0' }
androidx-core-testing = { module = 'androidx.arch.core:core-testing', version = '2.2.0' }
androidx-espresso-contrib = { module = 'androidx.test.espresso:espresso-contrib', version.ref = 'espresso' }
androidx-espresso-core = { module = 'androidx.test.espresso:espresso-core', version.ref = 'espresso' }
Expand Down Expand Up @@ -50,7 +50,7 @@ junit = { module = 'junit:junit', version = '4.13.2' }
leakcanary = { module = 'com.squareup.leakcanary:leakcanary-android', version = '2.14' }
material = { module = 'com.google.android.material:material', version = '1.12.0' }
materialvalues = { module = 'com.github.esnaultdev:MaterialValues', version = 'v1.1.1' }
mockito-core = { module = 'org.mockito:mockito-core', version = '5.14.2' }
mockito-core = { module = 'org.mockito:mockito-core', version = '5.15.2' }
mockito-inline = { module = 'org.mockito:mockito-inline', version = '5.2.0' }
moshi = { module = 'com.squareup.moshi:moshi', version = '1.15.2' }
okhttp3 = { module = 'com.squareup.okhttp3:okhttp', version.ref = 'okhttp3' }
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.8-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-all.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down

0 comments on commit 1d689ae

Please sign in to comment.