feat(transactions): added pagination to transactions #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NuttyShrimp
force-pushed
the
feat/paginated-transactions-api
branch
from
60694cf to
3b924ab
Compare
|
Would be nice to have these tested and added to the API specs at https://github.com/ZeusWPI/Tab/blob/master/spec/integration/api/v1/transactions_controller_spec.rb. This spec will automatically generate a swagger so users are aware the params exist. It's not explicitly needed to check for the params existence, using |
|
i've added the test (after some struggles) and also added ordering to the transactions. It think that's logical change to prevent users from getting unordered list's but I'm not sure if it is required to explicitly order by id |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time writing in this language so I'm open for criticism.
Adds the
limit=andstart=query parameters to the/api/v1/users/USERNAME/transactionsendpoint.closes #114