Embedded LND: delete + create multiple wallets

[kaloudis]

Description

Relates to issue: ZEUS-1649

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

• Embedded LND
• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (CLNRest)
• Nostr Wallet Connect
• LndHub

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[kaloudis]

Still need to potentially add a balance and channel check. Maybe we just need the latter?

[myxmaster]

The explainer needs to be adjusted:

[myxmaster]

Still need to potentially add a balance and channel check. Maybe we just need the latter?

In case there is on-chain balance only, a last reminder (info modal) about seed backup would be good I think.

And in case channels exist, an info modal should explain that channels should be closed first, otherwise force close will happen during recovery.

In both cases we should maybe even force the user to check a box to confirm that seed back up exists / he is aware of force close, to be able to proceed. I think more friction is acceptable here, because deleting the embedded node should be a rare case, and we know that still some users will complain because they don't have their seed or are annoyed by the waiting time/fees because of force closes...

[myxmaster]

When I have persistent mode disabled and then delete the embedded node, Zeus restarts and auto connects to my only other node config (polar LND REST in this case) and then I have a notification that LND is running in the background... This is on Android emulator Pixel_9_Pro_API_35.

[shubhamkmr04]

Frequently getting stopped by these errors while creating wallet

sub custom messages error: The first argument must be one of type string, Buffer, ArrayBuffer, Array, or Array-like Object. Received type undefined
channel acceptance error: The first argument must be one of type string, Buffer, ArrayBuffer, Array, or Array-like Object. Received type undefined
subscribe channel backups error: The first argument must be one of type string, Buffer, ArrayBuffer, Array, or Array-like Object. Received type undefined

[shubhamkmr04]

[kaloudis]

Frequently getting stopped by these errors while creating wallet

sub custom messages error: The first argument must be one of type string, Buffer, ArrayBuffer, Array, or Array-like Object. Received type undefined channel acceptance error: The first argument must be one of type string, Buffer, ArrayBuffer, Array, or Array-like Object. Received type undefined subscribe channel backups error: The first argument must be one of type string, Buffer, ArrayBuffer, Array, or Array-like Object. Received type undefined

This is normal. Happens when the embedded listener closes on subscribeChannelBackups

[kaloudis]

not sure why this is throwing. Perhaps @myxmaster has some insights

[myxmaster]

I only saw this when I forgot to rebuild...

[kaloudis]

Added warnings for deletion

Android

Active error	Channels warning	Balance warning

iOS

Active error	Channels warning	Balance warning