-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activity: Hide memos/keysend messages and notes when lurker mode is enabled #2782
Activity: Hide memos/keysend messages and notes when lurker mode is enabled #2782
Conversation
…s it internally already
Regarding the last commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
{keysendMessageOrMemo} | ||
{PrivacyUtils.sensitiveValue( | ||
keysendMessageOrMemo | ||
)?.toString()} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to convert to string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When i don't do it, I get:
No overload matches this call.
Overload 1 of 2, '(props: TextProps): Text', gave the following error.
Type 'string | number | Date | undefined' is not assignable to type 'ReactNode'.
Type 'Date' is not assignable to type 'ReactNode'.
Overload 2 of 2, '(props: TextProps, context: any): Text', gave the following error.
Type 'string | number | Date | undefined' is not assignable to type 'ReactNode'.
Type 'Date' is not assignable to type 'ReactNode'.ts(2769)
Text.d.ts(115, 3): The expected type comes from property 'children' which is declared here on type 'IntrinsicAttributes & IntrinsicClassAttributes<Text> & Readonly<TextProps>'
Text.d.ts(115, 3): The expected type comes from property 'children' which is declared here on type 'IntrinsicAttributes & IntrinsicClassAttributes<Text> & Readonly<TextProps>'
I think this is because PrivacyUtils.sensitiveValue()
can return string | number | Date | undefined
(because of this line: if (!lurkerMode) return input;
) and then <Text>
would be unhappy about a Date
type.
Description
Since we now display memos/keysend messages in Activity view, we need to care about hiding those in case lurker mode is enabled...
Notes also need to be hidden.
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: