Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format block height with commas #2627

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

shubhamkmr04
Copy link
Contributor

@shubhamkmr04
Copy link
Contributor Author

Screenshot_1734082878

@kaloudis should we also format some values here on this view ?

@kaloudis
Copy link
Contributor

Screenshot_1734082878

@kaloudis should we also format some values here on this view ?

Yes, let's do it

@kaloudis kaloudis linked an issue Dec 13, 2024 that may be closed by this pull request
@kaloudis kaloudis added this to the v0.9.4 milestone Dec 13, 2024
<KeyValue
keyValue={localeString(item.label)}
value={item.value}
value={
index < 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not crazy about using the index here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed few changes! would this work?

@shubhamkmr04 shubhamkmr04 force-pushed the shubham/format-with-commas branch from 5332ece to 4e9fef7 Compare December 15, 2024 13:19
Copy link
Contributor

@kaloudis kaloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit 56cb0b5 into ZeusLN:master Dec 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syncing wallet + Node Info: format block height values with commas
2 participants