Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded LND: Settings: add Custom Express Graph Sync server #2300

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

kaloudis
Copy link
Contributor

Description

This PR allows users to change their default Speedloader/Primer server used for Express Graph Sync. Users can pick the Olympus server, the Blixt server, or specify a custom host.

The settings can be found under Embedded Node > Express Graph Sync

simulator_screenshot_D8074AF1-9BB6-4A04-A5B1-74E98EDEA281

simulator_screenshot_54E5F052-1ED3-4B6B-BCA8-10EF724A7D4A

simulator_screenshot_95B6242B-F6EE-497E-B154-2C38A93DC9F9

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis force-pushed the custom-speedloader branch from 981c28b to 63622a2 Compare July 24, 2024 14:31
@kaloudis kaloudis changed the title Embedded LND: Settings: add Custom Speedloader server Embedded LND: Settings: add Custom Express Graph Sync server Jul 24, 2024
@kaloudis kaloudis merged commit 297d5a0 into ZeusLN:master Jul 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant