Skip to content

fix(cef): isolate embedded browser close on macOS - #3

Open
ryok90 wants to merge 1 commit into
tap/watch-resourcesfrom
fix/cef-embedded-child-close
Open

fix(cef): isolate embedded browser close on macOS#3
ryok90 wants to merge 1 commit into
tap/watch-resourcesfrom
fix/cef-embedded-child-close

Conversation

@ryok90

@ryok90 ryok90 commented Aug 12, 2026

Copy link
Copy Markdown

Summary

  • track the runtime-owned primary CEF browser separately from inherited popup browsers
  • intercept primary browser DoClose on macOS so CEF does not send performClose: to the Tauri parent window
  • complete browser destruction by removing only the native child view on the next event-loop turn

This fixes ZephyrCloudIO/ze-agency-tauri#8500, where closing an embedded Code webview while changing chat rooms hid and destroyed TAP's main window. The behavior is intentionally macOS-only; Windows and Linux retain their existing close paths.

Verification

  • cargo test -p tauri-runtime-cef --all-features
  • cargo check -p tauri-runtime-cef --all-features
  • cargo fmt --all -- --check
  • git diff --check

The commands pass with three pre-existing warnings in dock.rs, event_loop.rs, and window_builder.rs.

Manual Testing

  1. Build TAP on macOS with this Tauri revision.
  2. Open a chat room with an embedded Code surface.
  3. Create another channel so the old room's embedded CEF webview closes.
  4. Confirm the new channel opens and the TAP main window remains visible and registered.
  5. Return to the original room and confirm its Code surface can be created again.
  6. Quit TAP and confirm all CEF renderer helpers exit.

@github-actions

Copy link
Copy Markdown

Package Changes Through 379b959

There are 9 changes which include tauri with patch, tauri-utils with patch, tauri-build with patch, tauri-plugin with patch, tauri-macros with patch, tauri-codegen with patch, @tauri-apps/cli with patch, tauri-cli with patch, tauri-bundler with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-utils 2.9.3 2.9.4
tauri-bundler 2.9.4 2.10.0
tauri-runtime 2.11.3 2.11.4
tauri-runtime-wry 2.11.3 2.11.4
tauri-runtime-cef 0.1.0 0.1.1
tauri-codegen 2.6.3 2.6.4
tauri-macros 2.6.3 2.6.4
tauri-plugin 2.6.3 2.6.4
tauri-build 2.6.3 2.6.4
tauri 2.11.3 2.11.4
@tauri-apps/cli 2.11.4 2.11.5
tauri-cli 2.11.4 2.11.5

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@ryok90 ryok90 self-assigned this Aug 12, 2026
@ryok90

ryok90 commented Aug 12, 2026

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant