fix(cef): isolate embedded browser close on macOS - #3
Open
ryok90 wants to merge 1 commit into
Open
Conversation
Package Changes Through 379b959There are 9 changes which include tauri with patch, tauri-utils with patch, tauri-build with patch, tauri-plugin with patch, tauri-macros with patch, tauri-codegen with patch, @tauri-apps/cli with patch, tauri-cli with patch, tauri-bundler with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DoCloseon macOS so CEF does not sendperformClose:to the Tauri parent windowThis fixes ZephyrCloudIO/ze-agency-tauri#8500, where closing an embedded Code webview while changing chat rooms hid and destroyed TAP's main window. The behavior is intentionally macOS-only; Windows and Linux retain their existing close paths.
Verification
cargo test -p tauri-runtime-cef --all-featurescargo check -p tauri-runtime-cef --all-featurescargo fmt --all -- --checkgit diff --checkThe commands pass with three pre-existing warnings in
dock.rs,event_loop.rs, andwindow_builder.rs.Manual Testing