-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker): set HOME
environment variable explicitly in Dockerfile
#9333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HOME environment variable was defaulting to /root when the container started, causing cache directories to be incorrectly set up under /root/.cache/zebra instead of /home/zebra/.cache/zebra. This explicit setting ensures the HOME environment variable is correctly set to the zebra user's home directory.
5 tasks
oxarbitrage
approved these changes
Mar 22, 2025
aphelionz
pushed a commit
to ShieldedLabs/zebra-crosslink-staging
that referenced
this pull request
Apr 2, 2025
…ZcashFoundation#9333) The HOME environment variable was defaulting to /root when the container started, causing cache directories to be incorrectly set up under /root/.cache/zebra instead of /home/zebra/.cache/zebra. This explicit setting ensures the HOME environment variable is correctly set to the zebra user's home directory.
aphelionz
pushed a commit
to ShieldedLabs/zebra-crosslink-staging
that referenced
this pull request
Apr 2, 2025
…ZcashFoundation#9333) The HOME environment variable was defaulting to /root when the container started, causing cache directories to be incorrectly set up under /root/.cache/zebra instead of /home/zebra/.cache/zebra. This explicit setting ensures the HOME environment variable is correctly set to the zebra user's home directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-devops
Area: Pipelines, CI/CD and Dockerfiles
C-bug
Category: This is a bug
C-exclude-from-changelog
Category: The PR should be excluded from the changelog and release notes
P-Critical 🚑
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
HOME
environment variable was defaulting to/root
when the container started, causing cache directories to be incorrectly set up under/root/.cache/zebra
instead of/home/zebra/.cache/zebra
This happens as the user running the
entrypoint.sh
(before usinggosu
) is theroot
userThe initial intention was not to override the default linux
$HOME
, but in this controlled environment there's no actual benefit in not doing so.Solution
HOME
environment variable is correctly set to the zebra user's home directory.Tests
As their exit code is not being handled correctly
Follow-up Work
PR Checklist
C-exclude-from-changelog
label.