-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a scanning results reader #8104
Conversation
94cd2fd
to
161b510
Compare
161b510
to
c7d4ca6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I wonder if we could move some of this code into scan.rs
, or maybe a separate decrypt.rs
module? I could imagine two APIs:
- high-level: key string, transaction data bytes, Zebra network, height, returns Zebra typed memo data
- low-level: zcash_primitives key type, transaction type, network, heights, returns raw or zcash_primitives memo data
This could happen in a separate ticket.
Co-authored-by: teor <[email protected]>
Co-authored-by: teor <[email protected]>
Co-authored-by: teor <[email protected]>
Co-authored-by: teor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to merge this now and do any other changes in another PR. Or do the changes here. Totally up to you!
I'd prefer to make the changes here. I should be done by tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go! Then we can do some cleanups later.
Motivation
So far, we have only used
ldb
to print the contents of the storage with the scanning results. Since the results contain only TXIDs, we couldn't straightforwardly tell much about their properties.Depends-On: #8079.
PR Author Checklist
Check before marking the PR as ready for review:
Solution
Add a separate binary into
zebra-utils
that prints Zebra's scanning results:getrawtransaction
RPC.Add a tutorial describing how to use the tool.
Testing
I didn't add or change any tests.
Review
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.