Send AdvertiseTransactionIds to peers
#2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxarbitrage
commented
Oct 1, 2021
teor2345
reviewed
Oct 5, 2021
3 tasks
teor2345
reviewed
Oct 7, 2021
teor2345
reviewed
Oct 7, 2021
There was a problem hiding this comment.
Thanks for rebasing on top of my mempool refactor and gossip test PRs!
We could merge this PR as it is, but I think it's important that we test that the transaction gossip task doesn't panic or have errors.
Did you want to open the follow up ticket for skipping expired transactions and transactions that the mempool storage rejected? (I can do it if you want.)
2 tasks
Co-authored-by: teor <[email protected]>
Keeping the mempool around avoids a transaction broadcast task error, so we can test that there are no other errors in the task.
We want to be able to change the setup without changing the tests.
teor2345
reviewed
Oct 8, 2021
teor2345
reviewed
Oct 8, 2021
teor2345
approved these changes
Oct 8, 2021
There was a problem hiding this comment.
I'm ok with merging this, if @oxarbitrage is ok with my bug fix and cleanup.
|
Everything looks good here, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After any transaction is inserted into our mempool it must be broadcasted to active peers. Close #2758 when merged.
Solution
Add a watch channel to send inserted transactions from the mempool into a gossip transactions module. Some ideas for this are taken from #2729
Review
Maybe @jvff can do the initial review :)