Conversation
oxarbitrage
commented
Oct 6, 2020
oxarbitrage
commented
Oct 6, 2020
teor2345
suggested changes
Oct 8, 2020
Contributor
teor2345
left a comment
There was a problem hiding this comment.
This is a good start for a design!
Thanks for the tables and the headings, they make things a lot easier to read.
There's just a few things we need to tweak before we start implementing.
Co-authored-by: teor <teor@riseup.net>
It is clear from the signature that the function will return `Error` on any failure(including input errors, for example a wrong height). Describing this will force us to write it for all functions that returns an error so better remove it.
teor2345
reviewed
Oct 11, 2020
oxarbitrage
commented
Feb 22, 2021
Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
daira
reviewed
Feb 23, 2021
daira
reviewed
Feb 23, 2021
daira
reviewed
Feb 23, 2021
teor2345
suggested changes
Feb 24, 2021
Contributor
teor2345
left a comment
There was a problem hiding this comment.
We need to make changes based on Daira's suggestions.
Contributor
Author
|
I addressed all comments from @daira . Very appreciated, feel free to revisit the changes and let me know if any of them still need improvements. |
teor2345
reviewed
Feb 25, 2021
teor2345
reviewed
Feb 25, 2021
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: teor <teor@riseup.net>
teor2345
reviewed
Feb 25, 2021
Co-authored-by: teor <teor@riseup.net>
Contributor
|
Since we're checkpointing on Canopy, we can ignore Founders Reward validation. So we need to decide if we want to:
|
7 tasks
…rafts/xxxx-block-subsidy.md
Contributor
|
We've decided to merge this RFC as a draft for now, see #338 for more details. |
teor2345
reviewed
Mar 30, 2021
teor2345
reviewed
Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
See #338
Transaction Fee Validation Rules
Coinbase Source Validation Rules
Summary
Zebra manages semantic verification in the
zebra-consensuscrate, this is done for all incoming blocks. Inside each block the coinbase transaction is special, it holds the subsidy rewards that are paid to different participants(miners, founders, stream receivers). This RFC describes how to implement the needed calculations and verification for block subsidy and miner fees.More information
Feature Name:
block_subsidyStart Date: 2020-10-05
Design PR: ZcashFoundation/zebra#1129
Zebra Issue: None by now
Document
Rendered.
Zebra Team Approval
Everyone on the Zebra team should review design RFCs: