-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance decorator to check returned tuple dataframes and input dataframes #66
Open
drosengarten
wants to merge
10
commits into
ZaxR:master
Choose a base branch
from
drosengarten:feature/add_df_location_in_decorators
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enhance decorator to check returned tuple dataframes and input dataframes #66
drosengarten
wants to merge
10
commits into
ZaxR:master
from
drosengarten:feature/add_df_location_in_decorators
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync with bulwark
str: arg name of the input argument to the decorated function to check int: the entry in a tuple returned by the decorated function to check None: check the single dataframe return by the decorated function (default functionality for backward compatibility)
drosengarten
changed the title
Feature/add df location in decorators
Enhance decorator to check returned tuple dataframes and input dataframes
Jan 6, 2020
I will look into the issue on why it failed the linting under python 3.7, but not under 3.6/3.5 |
removed trailing spaces and ordered imports
added indent on test_multi_check parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code for issue 65: #65
The current implementation only allows a singular result dataframe checked
This change expands this functionality to allow the decorator to include checking returned dataframes in tuples as well as specifying input dataframes.