Temporary reverting passing generator locale from outside

YuriyIvon · Feb 28, 2024 · cf2efed · cf2efed
1 parent 80b03f4
commit cf2efed
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/DatabaseBenchmark/DataSources/Generator/GeneratorDataSource.cs b/src/DatabaseBenchmark/DataSources/Generator/GeneratorDataSource.cs
@@ -28,9 +28,9 @@ public GeneratorDataSource(string filePath, IDataSourceFactory dataSourceFactory
             var optionsDirectory = Path.GetDirectoryName(Path.GetFullPath(filePath));
             Directory.SetCurrentDirectory(optionsDirectory);
 
-            var faker = !string.IsNullOrEmpty(_options.Locale) ? new Faker(_options.Locale) : new Faker(); 
+            //var faker = !string.IsNullOrEmpty(_options.Locale) ? new Faker(_options.Locale) : new Faker(); 
 
-            var generatorFactory = new GeneratorFactory(faker, dataSourceFactory, database);
+            var generatorFactory = new GeneratorFactory(/*faker, */dataSourceFactory, database);
             _generators = _options.Columns
                 .Select(c => generatorFactory.Create(c.GeneratorOptions))
                 .ToArray();

diff --git a/src/DatabaseBenchmark/Generators/GeneratorFactory.cs b/src/DatabaseBenchmark/Generators/GeneratorFactory.cs
@@ -14,11 +14,11 @@ public class GeneratorFactory : IGeneratorFactory
         private readonly IDatabase _database;
         private readonly DataSourceIteratorGeneratorFactory _dataSourceIteratorGeneratorFactory;
 
-        public GeneratorFactory(Faker faker, IDataSourceFactory dataSourceFactory, IDatabase database)
+        public GeneratorFactory(IDataSourceFactory dataSourceFactory, IDatabase database)
         {
             _dataSourceIteratorGeneratorFactory = new DataSourceIteratorGeneratorFactory(dataSourceFactory);
             _database = database;
-            _faker = faker;
+            _faker = new Faker(); //TODO: pass faker or a locale from outside
         }
 
         public IGenerator Create(IGeneratorOptions options)

diff --git a/tests/DatabaseBenchmark.Tests/Common/RandomValueProviderTests.cs b/tests/DatabaseBenchmark.Tests/Common/RandomValueProviderTests.cs
@@ -28,7 +28,7 @@ public RandomValueProviderTests()
             _distinctValues = ["One", "Two", "Three", "Four", "Five", "Six", "Seven"];
 
             var columnPropertiesProvider = new TableColumnPropertiesProvider(table);
-            _randomGeneratorFactory = new GeneratorFactory(null, null, null);
+            _randomGeneratorFactory = new GeneratorFactory(null, null);
             var distinctValuesProvider = Substitute.For<IDistinctValuesProvider>();
             distinctValuesProvider.GetDistinctValues(_tableName, _distinctColumnName).Returns(_distinctValues);
             _randomValueProvider = new RandomValueProvider(_randomGeneratorFactory, columnPropertiesProvider, distinctValuesProvider);