Feature/change password dashboard #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yureien
requested changes
Dec 22, 2023
|
Hey @Yureien any updates on this pr? |
Yureien
requested changes
Feb 18, 2024
| @@ -24,7 +24,7 @@ | |||
| </script> | |||
|
|
|||
| <div class="p-2 min-h-screen w-screen flex flex-col text-primary"> | |||
| <div class="pb-4"> | |||
| <div> | |||
| return { settings: user?.settings as UserSettings }; | ||
| return { | ||
| settings: user?.settings as UserSettings, | ||
| username: user?.username as string, |
There was a problem hiding this comment.
Don't think we need to use as string, since it is already a string.
| > | ||
| {#if form?.defaultsForm !== undefined && form?.defaultsForm.success} | ||
| <span class="text-green-500">Saved</span> | ||
| <!-- {:else if form?.defaultsForm.error} |
There was a problem hiding this comment.
Can you remove the commented lines please?
| <button class="bg-amber-500 text-black text-lg px-4 py-1" | ||
| >Save</button | ||
| > | ||
| {#if form?.defaultsForm !== undefined && form?.defaultsForm.success} |
There was a problem hiding this comment.
Can be simplied as {#if form?.defaultsForm?.success}
| > | ||
| {#if form?.passwordForm?.success} | ||
| <span class="text-green-500">Saved</span> | ||
| {/if} |
There was a problem hiding this comment.
Can use if/else here instead of two different if statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes: #18
Adds the funtionality to change password through dashboard.