-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Trixie] Pydantic v2 #2005
Draft
Axolotle
wants to merge
59
commits into
trixie
Choose a base branch
from
enh-pydantic
base: trixie
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Trixie] Pydantic v2 #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n depending on optional + multiple
…al and as default
…to handle common parsing/serializing
…d do not strip text and password option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
Use new features of pydantic v2 to improve type coercing/validation.
Constraints:
Now use custom "validators" (constraints) that can be used directly in type definition but also as dynamic annotation.
Changed the way Option's annotation is built with those constraints
Option's
normalize
andhumanize
now properly validate passed values and serialize it depending on modes:normalize
for now but will next be called in a new methodstringify
humanize
to display human readable valuesnormalized
Those modes are also available to serialize a full form (
normal
mode will be used to serialize non app config panels settings)None:
Harmonized "none" values for every type,
(None, "", "none", "_none")
(and uppercase) are treated as None and serialized depending on type.New attributes: multiple
Options can now use
multiple: true
to accept a list of values, it will properly parse coma list string likeF1,F2,F3
as lists then will perform validation on each item. So you can usemultiple: true
ontype: string
with a custom pattern that will be used on all list items. All option types can bemultiple
exceptpassword|file
.Added some new tests with this attr.
Removed call to xfail/xpass in tests and fixed remaining parsing/validation errors
PR Status
WIP
TODO
normal
How to test
Yes