Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error and success emails formating, and included missing general borg logs in them #193

Open
wants to merge 2 commits into
base: testing
Choose a base branch
from

Conversation

eauchat
Copy link
Contributor

@eauchat eauchat commented Feb 10, 2025

Problem

  1. There are missing logs in the error email sent to admins, for example, if a repo's quota has been reached, this is logged in the general /var/log/borg/borg.log, and not in the operation log, so the admin won't see about it in the email and therefore have a harder time figuring out why backup failed.
  2. Emails could be more clear, there are logs from two different files but it looks like one single log, so one does not understand the chronology of the logs.

Solution

  1. Include last logs from /var/borg/<app>/borg.log in error emails.
  2. Improved the formatting of sent emails.

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant