Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exclude pattern #185

Open
wants to merge 4 commits into
base: testing
Choose a base branch
from
Open

add exclude pattern #185

wants to merge 4 commits into from

Conversation

kay0u
Copy link
Member

@kay0u kay0u commented Dec 28, 2024

Problem

  • We can't exclude files to the backup

Solution

  • Add an option to ignore some folders

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@fflorent
Copy link
Contributor

fflorent commented Jan 1, 2025

Shouldn't this feature be part of the yunohost backup create tool so it benefits to all backup methods?

Especially I feel like it would be confusing that the behaviour regarding .nobackup, since it already exists to exclude the data directories:
https://github.com/YunoHost/yunohost/blob/6388ef73c242aad86edd60bb05dfcd97733b97bc/hooks/backup/17-data_home#L33

@alexAubin
Copy link
Member

Yes it should be part of the core, but the core's default backup is using .tar, and the corresponding python library has no straightforward way to "exclude" patterns (let's say you want to backup a folder A, but not the subdir A/B, etc..)

@fflorent
Copy link
Contributor

fflorent commented Jan 1, 2025

OK then. Also it looks like it would be straightforward to generalize it when walking into the subdirectories is supported in the core.

@kay0u
Copy link
Member Author

kay0u commented Jan 12, 2025

I'd be happy to generalize it, but the tarfile library used for the backup doesn't have this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants