修复 TradeOrderUpdateService 的单元测试 #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YunaiV
reviewed
May 18, 2024
...z/src/main/java/cn/iocoder/yudao/module/trade/dal/dataobject/delivery/DeliveryExpressDO.java
Outdated
Show resolved
Hide resolved
YunaiV
reviewed
May 18, 2024
...z/src/test/java/cn/iocoder/yudao/module/trade/service/order/TradeOrderUpdateServiceTest.java
Outdated
Show resolved
Hide resolved
YunaiV
reviewed
May 18, 2024
| @@ -322,7 +322,7 @@ public class TradeOrderDO extends BaseDO { | |||
| * | |||
| * 关联 CombinationRecordDO 的 headId 字段 | |||
| */ | |||
| private Long combinationHeadId; | |||
| private Long combinationHeadId; // FIXME 2024/5/15: "团长" 应该译作 leader / starter 而不是 head | |||
There was a problem hiding this comment.
head 和 leader 都有哈。
这块先暂时不改，涉及的地方太多了。
There was a problem hiding this comment.
需要保留这个 FIXME 注释么?
|
已经第一轮 review，等待修改 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.