If onlySquare is enabled, execute fitImage on display. #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
keremcesme
suggested changes
Jan 29, 2023
|
With this fix, the selected image view can't be moved up when scrolling. Can you take a look? |
|
@keremcesme Thank you for your review. Videos in the library also used |
|
@ramboli1986 Did you run that in the sample app? I checked and it works fine in the sample app. |
Nvm, I can't repo it any more. Thanks for the fix. |
rance-attack
reviewed
Jun 7, 2023
Comment on lines
79
to
82
| strongSelf.squaredZoomScale = strongSelf.calculateSquaredZoomScale() | ||
| if YPConfig.library.onlySquare { | ||
| strongSelf.fitImage(true) | ||
| } |
There was a problem hiding this comment.
I think we can replace it with
strongSelf.fitImage(YPConfig.library.onlySquare || YPConfig.library.isSquareByDefault)
squaredZoomScale is calculated in fitImage()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#776
To fix above issue.
If
onlySquareis enabled when displaying an Asset, callfitImageto crop it to a square.You can see how it works in the sample apps in the
feature/demobranch.https://github.com/hanawat/YPImagePicker/tree/feature/demo