Skip to content

fix changing albums crash #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

fix changing albums crash #747

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
311c3c6
fix changing albums crash
Eslam-Salem Jun 1, 2022
d80023d
fix var type
Eslam-Salem Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Source/Pages/Gallery/YPLibraryVC+CollectionView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,16 @@ extension YPLibraryVC {
}

// MARK: - Library collection view cell managing
private func getSelectedIndexPaths(selectedItems: [YPLibrarySelection]) -> [IndexPath] {
let collectionViewItemsCount = v.collectionView.numberOfItems(inSection: 0)
var SelectedIndexPaths = [IndexPath]()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vars don't called uppercased in swift

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the typo. it is updated it

for item in selectedItems {
if item.index < collectionViewItemsCount {
SelectedIndexPaths.append(IndexPath(row: item.index, section: 0))
}
}
return Array(Set(SelectedIndexPaths))
}

/// Removes cell from selection
func deselect(indexPath: IndexPath) {
Expand All @@ -62,7 +72,7 @@ extension YPLibraryVC {
selectedItems.remove(at: positionIndex)

// Refresh the numbers
let selectedIndexPaths = selectedItems.map { IndexPath(row: $0.index, section: 0) }
let selectedIndexPaths = getSelectedIndexPaths(selectedItems: selectedItems)
v.collectionView.reloadItems(at: selectedIndexPaths)

// Replace the current selected image with the previously selected one
Expand Down