Dialog UI changes #1777
Open
Dialog UI changes #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds a temporary info popup in the add OATH account dialog.
This is to remove the ripple effect which is built into the PopupMenuItem.
fdennis
reviewed
Feb 4, 2025
dainnilsson
requested changes
Feb 4, 2025
lib/l10n/app_en.arb
Outdated
| "s_scanning": "Scanning (recommended)", | ||
| "p_scanning_desc": "Before scanning a QR code, make sure the full code is visible on screen.", | ||
| "s_drag_and_drop": "Drag and drop", | ||
| "p_drag_and_drop_desc": "An image containing a QR code may be dropped anywhere in the Accounts application.", |
There was a problem hiding this comment.
We use "application" to refer to actual code running on the YubiKey. I think we need something else to refer to the "view" in the app.
There was a problem hiding this comment.
Changed it to "view". Let me know what you think.
elibon99
force-pushed
the
elias/dialog-ui-changes
branch
from
ecaeb38 to
5afaf98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces UI related changes across the whole app. Example of changes include:
Move
leadingIcontoiconinTextFieldcomponents.Move text to info popups and
helperText.Use Basic dialogs (https://m3.material.io/components/dialogs/specs#23e479cf-c5a6-4a8b-87b3-1202d51855ac) for confirmation dialogs. These dialogs are smaller, with no blurred background and communicate the action to be performed in a more clear manner.