Fix bugs from CI tests

Yubico · Aug 6, 2024 · 16d1115 · 16d1115
1 parent 567d5ee
commit 16d1115
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/fido2/rpid.py b/fido2/rpid.py
@@ -68,7 +68,7 @@ def verify_rp_id(rp_id: str, origin: str) -> bool:
     if (
         url.scheme != "https"
         and (url.scheme, host) != ("http", "localhost")
-        and not (url.scheme == "http" and host.endswith(".localhost"))
+        and not (url.scheme == "http" and host and host.endswith(".localhost"))
     ):
         return False
     if host == rp_id:

diff --git a/tests/test_rpid.py b/tests/test_rpid.py
@@ -65,4 +65,4 @@ def test_localhost_http_secure_context(self):
         self.assertTrue(verify_rp_id("localhost", "http://example.localhost"))
         self.assertTrue(verify_rp_id("example.localhost", "http://example.localhost"))
         self.assertTrue(verify_rp_id("localhost", "http://localhost:8000"))
-
+        self.assertFalse(verify_rp_id("localhost", "http://"))