Using c11 #336
Merged
Using c11 #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we switch to C11, the availability of the memset_s function under Macos is detected by autoconf. The explicit_bzero.c module will use it to implement explicit_bzero(3) on that system. According to N1570, Annex K, in order for the string.h header to declare memset_s(), we need to define __STDC_WANT_LIB_EXT1__ as 1 before including the header file. The libc implementation is in turn supposed to define __STDC_LIB_EXT1__ in the header, to claim that the interfaces of Annex K are implemented as dictated by the standard. In theory, we should be using memset_s() only if __STDC_LIB_EXT1__ is defined, but we know that memset_s() exists thanks to autoconf. Since the Macos libc does not define __STDC_LIB_EXT1__, we can not be 100% sure that the memset_s() function is implemented in a standard way.
LDVG
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.