Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding additional device info fields to IYubikeyDeviceInfo #92

Merged
merged 23 commits into from
May 29, 2024
Merged

Adding additional device info fields to IYubikeyDeviceInfo #92

merged 23 commits into from
May 29, 2024

Conversation

DennisDyallo
Copy link
Collaborator

@DennisDyallo DennisDyallo commented May 20, 2024 •
edited
Loading

Description

Adds additional fields to the device info

  • FipsCapable
  • FipsApproved
  • PinComplexity
  • PartNumber
  • ResetBlocked

Fixes # YESDK-1290

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Ran locally and added integration/unit tests

Test configuration:

  • Firmware version: 5.7, 5.7 FIPS
  • Yubikey model: 5 USBA

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have run dotnet format to format my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@DennisDyallo DennisDyallo added documentation Improvements or additions to documentation enhancement New feature or request labels May 20, 2024
@DennisDyallo DennisDyallo changed the base branch from develop to feature/add-paging May 20, 2024 16:15
@github-actions GitHub Actions
Copy link

github-actions bot commented May 20, 2024 •
edited
Loading

Test Results: Windows

    2 files      2 suites   2s ⏱️
3 650 tests 3 650 ✅ 0 💤 0 ❌
3 652 runs  3 652 ✅ 0 💤 0 ❌

Results for commit 3e15626.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 20, 2024 •
edited
Loading

Test Results: Ubuntu

    2 files      2 suites   5s ⏱️
3 642 tests 3 642 ✅ 0 💤 0 ❌
3 644 runs  3 644 ✅ 0 💤 0 ❌

Results for commit 3e15626.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 20, 2024 •
edited
Loading

Test Results: MacOS

    2 files      2 suites   2s ⏱️
3 642 tests 3 642 ✅ 0 💤 0 ❌
3 644 runs  3 644 ✅ 0 💤 0 ❌

Results for commit 3e15626.

♻️ This comment has been updated with latest results.

Base automatically changed from feature/add-paging to develop May 21, 2024 15:12
@DennisDyallo DennisDyallo self-assigned this May 23, 2024
@DennisDyallo DennisDyallo marked this pull request as ready for review May 23, 2024 16:35
DennisDyallo
DennisDyallo commented May 23, 2024
View reviewed changes
Copy link
Collaborator Author

@DennisDyallo DennisDyallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review, need feedback on tostring overload.

@DennisDyallo DennisDyallo changed the title Adding additional device info fields Adding additional device info fields to IYubikeyDeviceInfo May 23, 2024
GregDomzalski
GregDomzalski reviewed May 23, 2024
View reviewed changes
Yubico.YubiKey/src/Yubico/YubiKey/IYubiKeyDeviceInfo.cs Outdated Show resolved Hide resolved
Yubico.YubiKey/src/Yubico/YubiKey/IYubiKeyDeviceInfo.cs Outdated Show resolved Hide resolved
Yubico.YubiKey/src/Yubico/YubiKey/IYubiKeyDeviceInfo.cs Show resolved Hide resolved
Yubico.YubiKey/src/Yubico/YubiKey/IYubiKeyDeviceInfo.cs Outdated Show resolved Hide resolved
Yubico.YubiKey/src/Yubico/YubiKey/IYubiKeyDeviceInfo.cs Outdated Show resolved Hide resolved
Yubico.YubiKey/src/Yubico/YubiKey/YubiKeyDeviceInfo.cs Outdated Show resolved Hide resolved
Yubico.YubiKey/src/Yubico/YubiKey/YubiKeyDeviceInfo.cs Show resolved Hide resolved
Yubico.YubiKey/src/Yubico/YubiKey/YubiKeyDeviceInfo.cs Outdated Show resolved Hide resolved
Yubico.YubiKey/src/Yubico/YubiKey/YubikeyDeviceManagementTags.cs Outdated Show resolved Hide resolved
Yubico.YubiKey/tests/unit/Yubico/YubiKey/YubikeyDeviceInfoTests.cs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Yubico.Core 41% 31% 4257 ➖
Yubico.YubiKey 51% 47% 18579 ➖
Summary 49% (31815 / 64599) 45% (8083 / 18108) 22836 ➖

Minimum allowed line rate is 40%

DennisDyallo
DennisDyallo commented May 29, 2024
View reviewed changes
Copy link
Collaborator Author

@DennisDyallo DennisDyallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed the PR feedback

AdamVe
AdamVe approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@AdamVe AdamVe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DennisDyallo DennisDyallo merged commit feef7e9 into develop May 29, 2024
13 checks passed
@DennisDyallo DennisDyallo deleted the feature/add-fields branch May 29, 2024 12:56
@DennisDyallo DennisDyallo mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@equijano21 equijano21 equijano21 left review comments

@AdamVe AdamVe AdamVe approved these changes

@GregDomzalski GregDomzalski GregDomzalski approved these changes

@dainnilsson dainnilsson Awaiting requested review from dainnilsson

@jensutbult jensutbult Awaiting requested review from jensutbult

Assignees

@DennisDyallo DennisDyallo

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DennisDyallo @dainnilsson @AdamVe @GregDomzalski @equijano21