Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up dotnet in dependent workflows #75

Merged
merged 20 commits into from
Apr 16, 2024
Merged

Set up dotnet in dependent workflows #75

merged 20 commits into from
Apr 16, 2024

Conversation

DennisDyallo
Copy link
Collaborator

Sometimes the dotnet format workflow would fail unexpectedly when the runner couldnt locate the dotnet executable. This PR attempts to address that matter.

@github-actions GitHub Actions
Copy link

Test Results

    2 files  ±0      2 suites  ±0   2s ⏱️ ±0s
3 615 tests ±0  3 615 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 617 runs  ±0  3 617 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6d0fd26. ± Comparison against base commit 043119a.

This pull request removes 25 and adds 25 tests. Note that renamed tests count towards both. 
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestHidDevice { LastAccessed = 2024-04-12T08:34:45.6084997+00:00, ParentDeviceId = null, Path = "", ProductId = 0, Usage = 0, ··· }, application: Fido2)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestHidDevice { LastAccessed = 2024-04-12T08:34:45.6084997+00:00, ParentDeviceId = null, Path = "", ProductId = 0, Usage = 0, ··· }, application: FidoU2f)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestHidDevice { LastAccessed = 2024-04-12T08:34:45.6085207+00:00, ParentDeviceId = null, Path = "", ProductId = 0, Usage = 0, ··· }, application: Otp)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T08:34:45.6085907+00:00, ParentDeviceId = null, Path = "" }, application: Fido2)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T08:34:45.6085907+00:00, ParentDeviceId = null, Path = "" }, application: FidoU2f)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T08:34:45.6085907+00:00, ParentDeviceId = null, Path = "" }, application: Management)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T08:34:45.6085907+00:00, ParentDeviceId = null, Path = "" }, application: Oath)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T08:34:45.6085907+00:00, ParentDeviceId = null, Path = "" }, application: OpenPgp)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T08:34:45.6085907+00:00, ParentDeviceId = null, Path = "" }, application: Otp)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T08:34:45.6085907+00:00, ParentDeviceId = null, Path = "" }, application: Piv)
…

Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestHidDevice { LastAccessed = 2024-04-12T10:42:48.9856964+00:00, ParentDeviceId = null, Path = "", ProductId = 0, Usage = 0, ··· }, application: Fido2)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestHidDevice { LastAccessed = 2024-04-12T10:42:48.9856964+00:00, ParentDeviceId = null, Path = "", ProductId = 0, Usage = 0, ··· }, application: FidoU2f)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestHidDevice { LastAccessed = 2024-04-12T10:42:48.9857255+00:00, ParentDeviceId = null, Path = "", ProductId = 0, Usage = 0, ··· }, application: Otp)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T10:42:48.9858301+00:00, ParentDeviceId = null, Path = "" }, application: Fido2)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T10:42:48.9858301+00:00, ParentDeviceId = null, Path = "" }, application: FidoU2f)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T10:42:48.9858301+00:00, ParentDeviceId = null, Path = "" }, application: Management)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T10:42:48.9858301+00:00, ParentDeviceId = null, Path = "" }, application: Oath)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T10:42:48.9858301+00:00, ParentDeviceId = null, Path = "" }, application: OpenPgp)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T10:42:48.9858301+00:00, ParentDeviceId = null, Path = "" }, application: Otp)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T10:42:48.9858301+00:00, ParentDeviceId = null, Path = "" }, application: Piv)
…

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 12, 2024 •
edited
Loading

publish test results

    2 files      2 suites   2s ⏱️
3 615 tests 3 615 ✅ 0 💤 0 ❌
3 617 runs  3 617 ✅ 0 💤 0 ❌

Results for commit 2b4e29b.

♻️ This comment has been updated with latest results.

@DennisDyallo DennisDyallo removed the request for review from GregDomzalski April 16, 2024 12:14
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Yubico.Core 43% 32% 1409 ➖
Yubico.YubiKey 53% 48% 6085 ➖
Summary 51% (8294 / 16290) 45% (2662 / 5929) 7494 ➖

Minimum allowed line rate is 33%

DennisDyallo
DennisDyallo commented Apr 16, 2024
View reviewed changes
Copy link
Collaborator Author

@DennisDyallo DennisDyallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just workflow adjustments, so I will go ahead merge them.

@DennisDyallo DennisDyallo merged commit 4d97399 into develop Apr 16, 2024
7 checks passed
@DennisDyallo DennisDyallo deleted the dennisdyallo/setup-dotnet branch April 16, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DennisDyallo