Skip to content

feat: Add support for Zlib compression/decompression #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DennisDyallo merged 6 commits into from
Mar 9, 2026
Merged

feat: Add support for Zlib compression/decompression #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9ddc5a2
Add ZlibStream class, check for compressed format in PivSession.KeyPa…
oskardanielsson-yubico Feb 24, 2026
3835601
Change naming, give exception instead of fallback during decompression
oskardanielsson-yubico Feb 24, 2026
b4a3c8a
Change header naming, add length check during decompression
oskardanielsson-yubico Feb 24, 2026
ee2a19f
Move exception strings to ExceptionMessages class
oskardanielsson-yubico Feb 25, 2026
5584386
fix: Address review issues in ZLib compression PR
github-actions[bot] Mar 6, 2026
34d0493
fix: Use index-from-end operator to resolve IDE0056 style error
github-actions[bot] Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 135 additions & 0 deletions Yubico.YubiKey/src/Resources/ExceptionMessages.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

45 changes: 45 additions & 0 deletions Yubico.YubiKey/src/Resources/ExceptionMessages.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,4 +916,49 @@
<data name="KeyAgreementReceiptMissmatch" xml:space="preserve">
<value>Key agreement receipts do not match</value>
</data>
<data name="GenerateKeyPairFailed" xml:space="preserve">
<value>Error generating key pair: {0}</value>
</data>
<data name="CertificateDataTooShortToDetectFormat" xml:space="preserve">
<value>Certificate data too short to determine compression format.</value>
</data>
<data name="CouldNotDetectCompressionFormat" xml:space="preserve">
<value>Could not detect compression format.</value>
</data>
<data name="DecompressedLengthMismatch" xml:space="preserve">
<value>Decompressed data length {0} does not match expected length {1} from GIDS header.</value>
</data>
<data name="StreamDoesNotSupportWriting" xml:space="preserve">
<value>The stream does not support writing.</value>
</data>
<data name="StreamDoesNotSupportReading" xml:space="preserve">
<value>The stream does not support reading.</value>
</data>
<data name="InvalidCompressionModeValue" xml:space="preserve">
<value>Invalid CompressionMode value.</value>
</data>
<data name="ReadingNotSupportedOnCompressionStreams" xml:space="preserve">
<value>Reading is not supported on compression streams.</value>
</data>
<data name="WritingNotSupportedOnDecompressionStreams" xml:space="preserve">
<value>Writing is not supported on decompression streams.</value>
</data>
<data name="CopyToNotSupportedOnCompressionStreams" xml:space="preserve">
<value>CopyTo is not supported on compression streams.</value>
</data>
<data name="CopyToAsyncNotSupportedOnCompressionStreams" xml:space="preserve">
<value>CopyToAsync is not supported on compression streams.</value>
</data>
<data name="UnexpectedEndOfZlibHeader" xml:space="preserve">
<value>Unexpected end of stream while reading zlib header.</value>
</data>
<data name="InvalidZlibHeaderChecksum" xml:space="preserve">
<value>Invalid zlib header checksum.</value>
</data>
<data name="UnsupportedZlibCompressionMethod" xml:space="preserve">
<value>Unsupported zlib compression method: {0}. Only deflate (8) is supported.</value>
</data>
<data name="ZlibPresetDictionaryNotSupported" xml:space="preserve">
<value>Zlib streams with a preset dictionary are not supported.</value>
</data>
</root>
Loading
Loading