Fixes #18 -- adding an error page directive for custom error pages #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need some tests and document for this. |
|
After I created some tests and played around with this for a while. I found this solution won't always work because vhost config is only created after you specify a CNAME for a certain project. For now, I can only make it possible for projects with CNAME to have customizable Any idea to solve this divergence? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an error page directive to each vhost. This allows custom 404 pages in the same way the official gitlab pages does: just add a 404.html to your project.
If you don't add a 404.html to your project, the behaviour is the same as today: a generic nginx 404 page.