Upgrade stylelint to 14.0.0

[rsstdd]

Updates stylelint and addresses issue #65.

[alies-dev]

hey @igorkamyshev @YozhikM Any news on this PR?

[igorkamyshev]

hey @igorkamyshev @YozhikM Any news on this PR?

Hey. Unfortunately, I have no permissions to merge PRs in this repo.

[alexander-akait]

@rsstdd Ping me on this weekend if there is no answer

[benbender]

Ping @alexander-akait :)

[rsstdd]

Ping @alexander-akait!

[thibaudcolas]

It looks like this plugin could use additional maintenance love – do the people currently involved with it take applications for new maintainers? I’d happily volunteer some of my time, accessibility-oriented rules feel invaluable for the whole stylelint ecosystem.

Apart from this peerDeps compatibility change, the project should also migrate from Travis to GitHub Actions like other stylelint projects have.

[ModulesUnraveled]

Yes! I just tried to install this, and found it's not compatible with stylelint 14. This is sorely needed. Thank you!

[alexander-akait]

Sorry, I am very busy, maybe someone wants to send a PR? That is PR 😄

[alexander-akait]

Can we add github actions (i.e. CI) here to run tests, because it is hard what it works fine with new version without problems?

[ModulesUnraveled]

It appears that @YozhikM is the only one with access to do that sort of thing. And he hasn't been active in a couple of years? I'm going to work on a fork to bring things up to date, unless or until this one can be maintained.

[alexander-akait]

No need to do fork, we need just add CI file here and I will merge

[benbender]

@alexander-akait implementation of a CI-workflow shouldn't be part of this PR imho. Separate topic, separate PR.

[alexander-akait]

Sorry, I can't merge it without test, I understand what it should be part of another commit (but I don't understand why do not include it here), but I can't merge it without verification, it can be broken

[ModulesUnraveled]

I'm not sure how to add to a fork PR like this. But this should work if it's created at .github/workflows/test.yml

on:
  pull_request:
    branches: ['master']
jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v2
      - name: Install Node.js
        uses: actions/setup-node@v2
        with:
          node-version: 16.13
      - name: Install
        run: npm ci
      - run: npm run test

[ModulesUnraveled]

Then, ideally, you'd update the settings for this repo to protect the master branch and require tests to pass before merging. Something like this: (but with the master branch, instead of main in the screenshot)

[benbender]

as we cant add to this pr, here is a separate one: #67

[benbender]

Additionally: The tests are clean for stylelint 14, but the (dev-)deps are vastly outdated and full security-issues and would need a serious overhault. This, in turn, would need a decision about the build-infrastructure and clean handling of cjs/esm as it is mixed atm and fails for upgraded deps.

[trdyer]

@alexander-akait Any chances on getting #67 merged so we can get movement on this?

[winston0410]

Hi will this PR be merged?

[thibaudcolas]

For people following this discussion – there’s now talks of either adding some of those rules to Stylelint itself or creating another community plugin similar to stylelint-a11y here: stylelint/stylelint#6212.

[liyokuna]

Hello, any news about this PR ?